Consolidating return types #7
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30ec126 to
043236b
Compare
Signed-off-by: Denis Makogon <denys.makogon@oracle.com>
- this method validates whether a converter can process the event, in case of structured converter this method does nothing, in case of binary converter this method raise an exception if an event is not v0.2 - adding (un)marshaller validation on being a callable object - tests added Signed-off-by: Denis Makogon <denys.makogon@oracle.com>
| @@ -25,6 +25,13 @@ class BinaryHTTPCloudEventConverter(base.Converter): | |||
| TYPE = "binary" | |||
| SUPPORTED_VERSIONS = [v02.Event, ] | |||
There was a problem hiding this comment.
Binary format was specified in v0.1 as well:
https://github.com/cloudevents/spec/blob/v0.1/http-transport-binding.md#31-binary-content-mode
evankanderson
added a commit
to evankanderson/sdk-python
that referenced
this pull request
Jan 13, 2019
Signed-off-by: Evan Anderson <argent@google.com>
|
|
||
| content_type = headers.get( | ||
| "content-type", headers.get("Content-Type")) | ||
|
|
||
| for _, cnvrtr in self.__converters.items(): |
There was a problem hiding this comment.
This is treating self.__converters as an unordered list (despite having been passed as an ordered list on line 102. dict randomization will mean that binary mode will sometimes be selected for a structured-mode request, which will cause test flakiness. (Discovered this by accident when re-running tests after fixing a lint error.)
There was a problem hiding this comment.
(I fixed this in #9)
evankanderson
added a commit
to evankanderson/sdk-python
that referenced
this pull request
Jan 13, 2019
Signed-off-by: Evan Anderson <argent@google.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #6
Closes: #4