Skip to content

Conversation

zhouse51
Copy link

hey @tyler-dunkel This service was done during the weekend, so the commit message didn't follow the semantic release commit message rule. I will keep it in mind for the future commits.

if (response && !isEmpty(response.List)) {
for (const instance of response.List) {
camPolicyList.push({
id: cuid(),
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tyler-dunkel @csbrandt
Note: I use the cuid() here instead of the instance's own PolicyID value, because the PolicyID value could be the same across different regions and cause graphql add mutation error.
Or maybe we can combine and use [region]-[PolicyID] as the id?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thats probably fine for now

} = service

return {
id: `${id}`,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is ${id} needed or can this just be id?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tyler-dunkel the id returns from the sdk is a number, our graphql base schema tencentBaseService defined the id as a string.
So we have to either use ${id} or id.toString()

@tyler-dunkel
Copy link
Contributor

LGTM but needs conflicts resolved @zhouse51

@zhouse51
Copy link
Author

zhouse51 commented Jun 2, 2022

@tyler-dunkel conflict resolved

@tyler-dunkel tyler-dunkel merged commit c0013d0 into alpha Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants