-
Notifications
You must be signed in to change notification settings - Fork 0
feat(camPolicy): add tencent cam policy #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
if (response && !isEmpty(response.List)) { | ||
for (const instance of response.List) { | ||
camPolicyList.push({ | ||
id: cuid(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tyler-dunkel @csbrandt
Note: I use the cuid() here instead of the instance's own PolicyID value, because the PolicyID value could be the same across different regions and cause graphql add mutation error.
Or maybe we can combine and use [region]-[PolicyID]
as the id?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thats probably fine for now
} = service | ||
|
||
return { | ||
id: `${id}`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is ${id}
needed or can this just be id?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tyler-dunkel the id returns from the sdk is a number, our graphql base schema tencentBaseService
defined the id as a string.
So we have to either use ${id}
or id.toString()
LGTM but needs conflicts resolved @zhouse51 |
@tyler-dunkel conflict resolved |
hey @tyler-dunkel This service was done during the weekend, so the commit message didn't follow the semantic release commit message rule. I will keep it in mind for the future commits.