Skip to content

fix: tests #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jul 29, 2024
Merged

fix: tests #118

merged 12 commits into from
Jul 29, 2024

Conversation

joshmanders
Copy link
Collaborator

This PR reverts illuminate/support and orchestra/testbench back to known working versions and fixes and backfills tests.

@joshmanders
Copy link
Collaborator Author

Before this PR can be merged, we need some env vars set on the repository.

  1. CLOUDINARY_URL
  2. TEST_FILE_URL -> Any file that exists in the bucket that can be tested with. I grabbed one of the sample ones from the media library in my account.

CC @colbyfayock

@colbyfayock
Copy link
Collaborator

hey @joshmanders would CLOUDINARY_URL be an environment variable for API Key/Secret? and the TEST_FILE_URL a full URL that links to an image?

had you considered mocking any of that to avoid the test runner to require a .env? im not strictly opposed but generally just makes it easier to not have to hit the actual API both from a contributor and usage perspective

@joshmanders
Copy link
Collaborator Author

@colbyfayock yes CLOUDINARY_URL is the cloudinary://.... api key info. and TEST_FILE_URL is a full url to a file.

I had considered mocking stuff, I'll do that and see if we can get around these needs with that, today.

@joshmanders joshmanders marked this pull request as ready for review July 26, 2024 22:51
@joshmanders joshmanders merged commit 20082c2 into master Jul 29, 2024
1 check passed
@joshmanders joshmanders deleted the fix/tests branch July 29, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants