Skip to content

Use GitHub actions for continuous integration (CI) #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 2, 2021
Merged

Use GitHub actions for continuous integration (CI) #24

merged 2 commits into from
Mar 2, 2021

Conversation

SimonFrings
Copy link
Contributor

Bye bye Travis CI, you've served us well.
This code supports running tests on PHP 8.

$ docker run -it --rm -v `pwd`:/data --workdir=/data php:8.0.0 php vendor/bin/phpunit
PHPUnit 9.5.2 by Sebastian Bergmann and contributors.

SSSSSSSSSSS...................................................... 65 / 79 ( 82%)
..............                                                    79 / 79 (100%)

Time: 00:00.050, Memory: 8.00 MB

OK, but incomplete, skipped, or risky tests!
Tests: 79, Assertions: 104, Skipped: 11.

Builds on top of #22 and reactphp/reactphp#442.

clue
clue approved these changes Mar 2, 2021
View reviewed changes
Copy link
Owner

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonFrings Thanks for the update, changes LGTM! :shipit:

@clue clue added this to the v1.3.0 milestone Mar 2, 2021
@clue clue merged commit c12f07e into clue:master Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clue clue clue approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@SimonFrings @clue