🔧 Support Electron v4 #152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/es6/runtimePaths.js
Outdated
| @@ -79,7 +79,7 @@ let runtimePaths = { | |||
| name: "node.lib" | |||
| }], | |||
| tarPath: "node" + "-v" + targetOptions.runtimeVersion + ".tar.gz", | |||
| headerOnly: false | |||
| headerOnly: semver.gte(targetOptions.runtimeVersion, '>=4.0.0-alpha') | |||
There was a problem hiding this comment.
That should be semver.satfisfies, because you've included the gte operator in the semver string.
There was a problem hiding this comment.
Switched to not include the >= operator in the semver string
|
@unbornchikken When it will be released? |
|
It'd be great to get an Electron 4-compatible cmake-js! |
|
It has been release just now as of 5.0.0. |
|
Fantastic, thanks @unbornchikken! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Electron 4 changed the header directory to use the 'headerOnly' format rather than the 'full' node checkout format.