Skip to content

Fix cmake generator #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 2, 2019
Merged

Fix cmake generator #161

merged 1 commit into from
Apr 2, 2019

Conversation

topecongiro
Copy link
Contributor

The output of cmake -E capabilities has Win64 suffix, so we need not add it manually. Closes #160.

{
  "generators": [
    {
      "extraGenerators": [],
      "name": "Visual Studio 15 2017 Win64",
      "platformSupport": true,
      "toolsetSupport": true
    },
    {
      "extraGenerators": [],
      "name": "Visual Studio 15 2017",
      "platformSupport": true,
      "toolsetSupport": true
    },
    {
      "extraGenerators": [],
      "name": "Visual Studio 15 2017 ARM",
      "platformSupport": true,
      "toolsetSupport": true
    },
    {
      "extraGenerators": [],
      "name": "Visual Studio 14 2015",
      "platformSupport": true,
      "toolsetSupport": true
    },
    {
      "extraGenerators": [],
      "name": "Visual Studio 12 2013 Win64",
      "platformSupport": true,
      "toolsetSupport": true
    },
    {
      "extraGenerators": [],
      "name": "Visual Studio 14 2015 Win64",
      "platformSupport": true,
      "toolsetSupport": true
    },
    {
      "extraGenerators": [],
      "name": "Visual Studio 12 2013",
      "platformSupport": true,
      "toolsetSupport": true
    },
    {
      "extraGenerators": [
        "CodeBlocks",
        "CodeLite",
        "Sublime Text 2",
        "Kate",
        "Eclipse CDT4"
      ],
      "name": "MinGW Makefiles",
      "platformSupport": false,
      "toolsetSupport": false
    },
    {
      "extraGenerators": [],
      "name": "Visual Studio 12 2013 ARM",
      "platformSupport": true,
      "toolsetSupport": true
    },
    {
      "extraGenerators": [],
      "name": "Visual Studio 14 2015 ARM",
      "platformSupport": true,
      "toolsetSupport": true
    },
    {
      "extraGenerators": [],
      "name": "Visual Studio 11 2012",
      "platformSupport": true,
      "toolsetSupport": true
    },
    {
      "extraGenerators": [],
      "name": "Visual Studio 11 2012 ARM",
      "platformSupport": true,
      "toolsetSupport": true
    },
    {
      "extraGenerators": [
        "CodeBlocks",
        "CodeLite",
        "Sublime Text 2",
        "Kate",
        "Eclipse CDT4"
      ],
      "name": "Unix Makefiles",
      "platformSupport": false,
      "toolsetSupport": false
    },
    {
      "extraGenerators": [],
      "name": "Visual Studio 11 2012 Win64",
      "platformSupport": true,
      "toolsetSupport": true
    },
    {
      "extraGenerators": [],
      "name": "Visual Studio 10 2010 Win64",
      "platformSupport": true,
      "toolsetSupport": true
    },
    {
      "extraGenerators": [],
      "name": "Visual Studio 10 2010",
      "platformSupport": true,
      "toolsetSupport": true
    },
    {
      "extraGenerators": [],
      "name": "Visual Studio 10 2010 IA64",
      "platformSupport": true,
      "toolsetSupport": true
    },
    {
      "extraGenerators": [],
      "name": "Visual Studio 9 2008",
      "platformSupport": true,
      "toolsetSupport": false
    },
    {
      "extraGenerators": [],
      "name": "Visual Studio 9 2008 Win64",
      "platformSupport": true,
      "toolsetSupport": false
    },
    {
      "extraGenerators": [
        "CodeBlocks"
      ],
      "name": "NMake Makefiles JOM",
      "platformSupport": false,
      "toolsetSupport": false
    },
    {
      "extraGenerators": [],
      "name": "Visual Studio 9 2008 IA64",
      "platformSupport": true,
      "toolsetSupport": false
    },
    {
      "extraGenerators": [],
      "name": "MSYS Makefiles",
      "platformSupport": false,
      "toolsetSupport": false
    },
    {
      "extraGenerators": [],
      "name": "Borland Makefiles",
      "platformSupport": false,
      "toolsetSupport": false
    },
    {
      "extraGenerators": [
        "CodeBlocks",
        "CodeLite",
        "Sublime Text 2",
        "Kate",
        "Eclipse CDT4"
      ],
      "name": "NMake Makefiles",
      "platformSupport": false,
      "toolsetSupport": false
    },
    {
      "extraGenerators": [],
      "name": "Green Hills MULTI",
      "platformSupport": true,
      "toolsetSupport": true
    },
    {
      "extraGenerators": [
        "CodeBlocks",
        "CodeLite",
        "Sublime Text 2",
        "Kate",
        "Eclipse CDT4"
      ],
      "name": "Ninja",
      "platformSupport": false,
      "toolsetSupport": false
    },
    {
      "extraGenerators": [],
      "name": "Watcom WMake",
      "platformSupport": false,
      "toolsetSupport": false
    }
  ],
  "serverMode": true,
  "version": {
    "isDirty": false,
    "major": 3,
    "minor": 13,
    "patch": 2,
    "string": "3.13.2",
    "suffix": ""
  }
}

@PaulFreund
Copy link

Tested for ia32 and x64 builds, merge and release would be highly appreciated :)

@anoadragon453
Copy link

Can confirm this fixed build issues for https://github.com/wilix-team/iohook 👍

@unbornchikken unbornchikken merged commit 13c8671 into cmake-js:master Apr 2, 2019
@unbornchikken
Copy link
Member

Ty.

@topecongiro
Copy link
Contributor Author

@unbornchikken Thanks! Do you have any plan to make a new release anytime soon?

@unbornchikken
Copy link
Member

Fixed as of v5.1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid default generator "Visual Studio 15 2017 Win64 Win64"
4 participants
@topecongiro @PaulFreund @anoadragon453 @unbornchikken