Fix visual c++ detection via vswhere #171
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here is my Python script that has been able to find def find_ms_build():
path = ""
cmd = subprocess.Popen('"%ProgramFiles(x86)%/Microsoft Visual Studio/Installer/vswhere.exe" -nologo -latest -property installationPath', shell=True, stdout=subprocess.PIPE)
for line in cmd.stdout:
path = str(line).replace('b\'', '').replace('\\r\\n\'', '').replace('\\\\', '\\')
return "{}/MSBuild/Current/Bin/MSBuild.exe".format(path)EDIT: Figured I may as well convert it to JS to make it a bit easier to use: var exec = require('child_process').execSync;
function findMSBuild() {
const replaceAll = (str, search, replacement="") => [...str.split(search)].join(replacement);
const buffer = exec('"%ProgramFiles(x86)%/Microsoft Visual Studio/Installer/vswhere.exe" -nologo -latest -property installationPath');
let path = buffer.toString();
path = replaceAll(path, "\r", "");
path = replaceAll(path, "\n", "");
path = replaceAll(path, "\\r\\n", "");
path = replaceAll(path, "\\\\", "/");
path = replaceAll(path, "\\", "/");
return path + "/MSBuild/Current/Bin/MSBuild.exe";
}
console.log(`Location of MSBuild.exe: '${findMSBuild()}'`); |
|
After looking into the code more I thought it would be best to open a new pull request with different changes #178 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements vswhere detection as per #100 (comment) and vswhere wiki
Until now this has only been tested on a build server with VS build tools installed, but I will deploy this patch to a team with ~30 people in the coming weeks and report back how well it performed.