Auto-detect Visual Studio 2019 platform #201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VS 2019 doesn't have the platform name in its name anymore, to generate the files for a specific platform you need to use "-A" option when invoking CMake.
The CMake Visual Studio 2019 Generator does not support the Win64 or ARM suffix on the generator name. Instead the generator platform must be set explicitly via the platform parameter. Before this patch the platform was not set at all which results in CMake picking the host architecture. This obviously leads to mismatches if a 32bit NodeJS is used on a 64bit Windows. Right now the platform parameter is only applied for Visual Studio 16 because cmake-js does not specify a minimum CMake version. If at least CMake 3.1 (released December 2014) would be required the platform selection code could be made unconditional and thus forward-compatible with newer CMake Visual Studio generators. Thanks to @wopss for cmake-js#177 which added platform parameter support.
|
I published a cmake-js version containing this patch as @gjasny/cmake-js. We successfully use it with Visual Studio 2017 and 2019 generators as well as Win32 and x64 target platforms. |
|
If you could make a readme section in this PR, I will make it into a release. |
|
I try to make a release tonight (UTC). |
|
Released as of 6.1 |
|
Thank you for working on that! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CMake Visual Studio 2019 Generator does not support the Win64 or ARM suffix on the generator name. Instead the generator platform must be set explicitly via the platform parameter.
Before this patch the platform was not set at all which results in CMake picking the host architecture. This obviously leads to mismatches if a 32bit NodeJS is used on a 64bit Windows.
Right now the platform parameter is only applied for Visual Studio 16 because cmake-js does not specify a minimum CMake version. If at least CMake 3.1 (released December 2014) would be required the platform selection code could be made unconditional and thus forward-compatible with newer CMake Visual Studio generators.
Thanks to @wopss for #177 which added platform parameter support.