-
Notifications
You must be signed in to change notification settings - Fork 146
Feature: add offline mode #260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: add offline mode #260
Conversation
Better if this doesn't have to be change in the package.json, and it's compatible with node-gyp arguments and environment variables:
|
With the npm set nodedir="runtime-directory" Will set the |
- Use the runtimeDirectory as the full path if defined, otherwise, keep it as it was
Ok, so now this PR only adds the possibility to configure the npm_config variable "nodedir" and use it as the internalPath. If the runtime is not already there it will try to download it. |
Would it be possible to have a working example for how to enable the custom node directory?
does not seem to work. |
The way I tested it is the following:
|
npm ERR! regardless of the path I use. It is not very clear how this is supposed to work. But one odd thing is that in |
Adds the options to disable the ensureInstalled and ensureDownload, and the option to set a custom directory where the runtime headers will be downloaded.
Currently it always checks for installed and downloaded, even when running
cmake-js clean
This PR keeps the default behavior as it is, but gives the option to change the settings in the
package.json
just as it works for "runtime", "runtimeVersion", and "arch":With
"ensureDownloaded": false
only thecmake-js install
command will check for download status and perform a download if it is needed.ensureInstalled
is true since it is not defined.The
runtimeDir
is the one to join theenvironment.home
to form theinternalPath
, instead of "runtime + arch + version"This might solve the issue #254