Add cmake-js options command
#288
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Julusian, as I can see you are the maintainer of this repo, so would be great to have your opinion here :) |
| @@ -199,13 +204,46 @@ CMake.prototype.getConfigureCommand = async function (nodeLibDefPath) { | |||
| for (const [key, value] of Object.entries(this.cMakeOptions)) { | |||
| D.push({ [key]: value }); | |||
| } | |||
| if (this.toolset.cppCompilerPath) { | |||
There was a problem hiding this comment.
I am not sure all of these options should be there though, but it is to be discussed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Idea
I want to try cmake-js in project which is CMake-based, but it is not only NodeJs addon, but also usual C++ library, so in our CI we will have to use not only cmake-js commands, but also usual CMake commands too, i.e. it leads to a lot of if-else in CI code(
if node_addon: cmake-js .. else: cmake ..). The idea is to continue using CMake, but with a little help of cmake-js when we build Node-related things, i.e. something like this:So this PR is draft implementing this use case, but before polishing it would be great to hear maintainers opinion :)