-
Notifications
You must be signed in to change notification settings - Fork 146
Add win_delay_load_hook.c #322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
It looks like the only difference is the line I've tried to write a test which triggers this issue, but I can't find how to tell cmake to disable the use of c++ so it builds successfully with the c++ version of the hook. How have you done it? https://github.com/cmake-js/cmake-js/tree/test/node-api-c |
If you run your test, you could find the following line in
Though the lib is built without error, the |
I don't know CMake enough to know if |
Of course.. very helpful of them to hide a misconfiguration that will cause build and/or runtime errors I am open to merging this as-is, but I would like to consider options to make it more idiot proof first, even though it would appear that needing this to be in c is rare enough to not warrant much effort. Perhaps if it was named |
The |
Support windows delay load hook in C.
I create a new MACRO for c source as I'm not sure if there is a better way to detect the project language in cmake-js. Feel free to update the PR.