refactor: refactor DispatchDomainEventsAsync #94
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikesnowy
requested changes
May 3, 2023
| @@ -173,6 +173,12 @@ private async Task ExtraAndPublishDomainEventsAsync() | |||
| var entities = Context.ExtractDomainEventSources(); | |||
| var domainEvents = entities.SelectMany(x => x.DomainEvents!.OfType<DomainEvent>()).ToList(); | |||
| entities.ForEach(x => x.ClearDomainEvents()); | |||
|
|
|||
| if (domainEvents is null || domainEvents.Any() == false) | |||
There was a problem hiding this comment.
这个在 ExtractDomainEventSources 里已经检查过了。
public static List<IDomainEventSource> ExtractDomainEventSources(this DbContext ctx)
{
var domainEntities = ctx.ChangeTracker
.Entries<IDomainEventSource>()
.Where(x => x.Entity.DomainEvents != null && x.Entity.DomainEvents.Any())
.Select(x => x.Entity)
.ToList();
return domainEntities;
}| } | ||
| else | ||
| { | ||
| await mediator.Publish(domainEvent); |
There was a problem hiding this comment.
判断之后两个分支都执行的同样的语句，那为什么要判断呢？
There was a problem hiding this comment.
可以直接让 IDomainEvent 继承 INotification。
| { | ||
| try |
There was a problem hiding this comment.
这个 Try...Catch 目的是当出现异常时保证其他领域事件被发布，这样后续如果要回滚可以直接全部回滚。不 catch 的话领域事件发到一半就挂了，剩下的不会被发布，而且不知道哪些发了哪些没发，导致一致性出现问题。设计上领域事件是顺序无关的，编程时不应该考虑领域事件的添加顺序。
这里把多的异常吃了确实是个问题，等下我加个 CombinedException 汇总一下异常再统一抛出来。
| @@ -15,22 +15,21 @@ public static class DispatchDomainEventExtensions | |||
| /// <param name="events">要发布的领域事件。</param> | |||
| public static async Task DispatchDomainEventsAsync(this IMediator mediator, IEnumerable<IDomainEvent> events) | |||
| { | |||
| Exception? e = null; | |||
| foreach (var domainEvent in events) | |||
| foreach (var domainEvent in events ?? Enumerable.Empty<IDomainEvent>()) | |||
There was a problem hiding this comment.
本来开了 nullable reference 是不需要判空的，实在要判的话也应该直接返回而不是新建一个空数组。
|
看起来是在没开 nullable reference 的项目里试图直接注入 IMediator 发领域事件，然后领域事件类直接继承的 IDomainEvent 而不是 DomainEvent 出现的问题。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.