アーキテクチャ構成の修正案 #59
Merged
アーキテクチャ構成の修正案 #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
毎回homeのconfを参照する件は、うまいことconfの情報をどこかにcacheできないのかなと思いつつ |
|
log.Fatalは |
|
serviceではconfの読み込みはしないというルールを設けてる |
|
ローカルでのメッセージ切り替え完了。 |
added 2 commits
October 6, 2023 02:20
mochi-yu
requested changes
Oct 11, 2023
| @@ -18,7 +18,7 @@ var ( | |||
| {}, | |||
| {int(entity.EN), int(entity.JP)}, | |||
| {int(entity.NormalFormat), int(entity.EmojiFormat), int(entity.PrefixFormat)}, | |||
| {int(entity.WrapServer), int(entity.OpenAiAPI)}, | |||
| {int(entity.Server), int(entity.Local)}, | |||
There was a problem hiding this comment.
ここのentity.Localが変数名間違えている？
There was a problem hiding this comment.
InputOutputという名前は抽象的すぎる気がする
There was a problem hiding this comment.
これをGitGatewayにしようかな
gitコマンドを操作してる感じだし
Comment on lines
+11
to
+13
| type GithubService interface { | ||
| GetStaginCodeDiff() (string, error) | ||
| } |
There was a problem hiding this comment.
Gitっていうツールではなく、GitHubっていう抽象的な概念に焦点当てた感じかな。
あとから、GithubのOAuthのメソッドもここにいれるつもりだった。
There was a problem hiding this comment.
GitHubは概念ではなく、Gitのリモートリポジトリを管理する１サービスじゃない？
There was a problem hiding this comment.
GithubがGitを包括するって意味で言いたかった!
でGithubServiceはGithubに関係するロジックをまとめたかったのが意図ではある。
わかりにくければGitにするわ
cocoide
added a commit
that referenced
this pull request
Nov 6, 2023
Merge pull request #59 from cocoide/feature/refactor-proposal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.