ディレクトリ名の変更 #8
Merged
ディレクトリ名の変更 #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 5, 2023 10:48
added 2 commits
October 5, 2023 11:49
mochi-yu
reviewed
Oct 11, 2023
There was a problem hiding this comment.
‘pkg/mock/openai.go‘とpkg/mock/deepl.goの中身、全く同じじゃない？これはこのままで良いの？
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
変更点
・pkg→internalに変更
・pkg配下には、mockとgrpcディレクトリを配置
・gateway層のinterfaceをdomain serviceに移行
→ 命名もドメインを意識したものに変更
(gatewayは元々infra層のようなものだと考えていた)
・grpcのpbにDIする層をservice→handlerに変更
補足
go get github.com/cocoide/commitify-grpc-server/pkg/grpc
でprobufの生成ファイルが使えるようにした