Skip to content

Conversation

pull[bot]
Copy link

@pull pull bot commented Aug 29, 2025

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.3)

Can you help keep this open source service alive? 💖 Please sponsor : )

mjbvz and others added 16 commits August 28, 2025 10:43
* restrict dialog to less than 5 files

* add warning dialog
Throw if accessing lazy value in its initializer
Include resource parameter in token exchange requests for OAuth2 flow to comply with RFC 8707.
The resource indicator was previously only included in the authorization request but missing
from both the authorization code and refresh token exchange requests.

This fix ensures that when a resource is specified in the metadata, it is consistently
included in all OAuth2 requests:
- Authorization request (already implemented)
- Authorization code for token exchange (now fixed)
- Refresh token exchange (now fixed)

Fixes #261364

Co-authored-by: Gautam <gautam.goudar@carvana.com>
Co-authored-by: Tyler James Leonhardt <2644648+TylerLeonhardt@users.noreply.github.com>
* fix: confirm response based on promise

When using the new `workbench.action.chat.open.blockOnResponse`
feature, if the VSC instance was in auto-approve mode, it was observed
that the command was resolving before the tool finished invocation.

This resulted in a race betwee sync and async code:

```
		if (!this._confirmationMessages) {
			// No confirmation needed
			this._isConfirmed = { type: ToolConfirmKind.ConfirmationNotNeeded };
			this._confirmDeferred.complete(this._isConfirmed);
		}
```

and then the check for confirmation in `isConfirmed`.

* remove _isConfirmed in favor of always the promise
* better reasoning rendering

* settings cleanup

* another settings update, changing defaults

* some more cleanup, no more helper func
* hide chat footer (#263519)

* add css
* Add a log statement for acquireTokenSilent

* stringify
@pull pull bot locked and limited conversation to collaborators Aug 29, 2025
@pull pull bot added the ⤵️ pull label Aug 29, 2025
@pull pull bot merged commit 5b25d49 into code:main Aug 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.