forked from microsoft/vscode
-
Notifications
You must be signed in to change notification settings - Fork 0
[pull] main from microsoft:main #346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+315
−112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* restrict dialog to less than 5 files * add warning dialog
Throw if accessing lazy value in its initializer
Include resource parameter in token exchange requests for OAuth2 flow to comply with RFC 8707. The resource indicator was previously only included in the authorization request but missing from both the authorization code and refresh token exchange requests. This fix ensures that when a resource is specified in the metadata, it is consistently included in all OAuth2 requests: - Authorization request (already implemented) - Authorization code for token exchange (now fixed) - Refresh token exchange (now fixed) Fixes #261364 Co-authored-by: Gautam <gautam.goudar@carvana.com> Co-authored-by: Tyler James Leonhardt <2644648+TylerLeonhardt@users.noreply.github.com>
* fix: confirm response based on promise When using the new `workbench.action.chat.open.blockOnResponse` feature, if the VSC instance was in auto-approve mode, it was observed that the command was resolving before the tool finished invocation. This resulted in a race betwee sync and async code: ``` if (!this._confirmationMessages) { // No confirmation needed this._isConfirmed = { type: ToolConfirmKind.ConfirmationNotNeeded }; this._confirmDeferred.complete(this._isConfirmed); } ``` and then the check for confirmation in `isConfirmed`. * remove _isConfirmed in favor of always the promise
* better reasoning rendering * settings cleanup * another settings update, changing defaults * some more cleanup, no more helper func
…allation and entitlement state (#263942)
* Add a log statement for acquireTokenSilent * stringify
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.3)
Can you help keep this open source service alive? 💖 Please sponsor : )