Skip to content

[pull] canary from vercel:canary #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 2, 2025
Merged

[pull] canary from vercel:canary #88

merged 3 commits into from
May 2, 2025

Conversation

pull[bot]
Copy link

@pull pull bot commented May 2, 2025

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.1)

Can you help keep this open source service alive? 💖 Please sponsor : )

mischnic and others added 3 commits May 2, 2025 18:23
…8771)

Closes PACK-4511

Concerning that we have test coverage for this never the deployment test never ran with Turbopack: #78768

This never (?) worked: 

```js
const wasm_vercel_og__resvg = require("...");
function loadWebAssemblyModule() {
	console.log(globalThis["wasm_vercel_og__resvg"]); // undefined
}
loadWebAssemblyModule();
```



Webpack generates the following, so let's do that as well
```js
const wasm_77d9faebf7af9e421806970ce10a58e9d83116d7 = require("/wasm/wasm_77d9faebf7af9e421806970ce10a58e9d83116d7.wasm");
.....
/***/ "(rsc)/../../node_modules/.pnpm/next@15.4.0-canary.12_react-dom@19.0.0_react@19.0.0/node_modules/next/dist/compiled/@vercel/og/resvg.wasm?module":
/***/ ((module) => {
module.exports = wasm_77d9faebf7af9e421806970ce10a58e9d83116d7;
/***/ }),
```
…waited (#75971)

The [promise created for updating the incremental cache on successful
fetches](https://github.com/vercel/next.js/blob/106e17ca8f093899d300885938eab863ffa478a7/packages/next/src/server/lib/patch-fetch.ts#L687-L728)
is not used, returned nor awaited in any way. I imagine that this can be
fine in environments such as Node.js servers where the dangling promise
will eventually run, in other environments however the promise might be
cancelled causing the cache update not to happen, so it would be
appropriate, when possible that the promise is awaited using `waitUntil`
(for more context, I've encountered this issue in the [OpenNext
project](https://github.com/opennextjs)).

So in this PR I'm adding the promise to the `pendingRevalidates` map so
that it will eventually be properly awaited.

cc. @vicb, @conico974

<!-- Thanks for opening a PR! Your contribution is much appreciated.
To make sure your PR is handled as smoothly as possible we request that
you follow the checklist sections below.
Choose the right checklist for the change(s) that you're making:

## For Contributors

### Improving Documentation

- Run `pnpm prettier-fix` to fix formatting issues before opening the
PR.
- Read the Docs Contribution Guide to ensure your contribution follows
the docs guidelines:
https://nextjs.org/docs/community/contribution-guide

### Adding or Updating Examples

- The "examples guidelines" are followed from our contributing doc
https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md
- Make sure the linting passes by running `pnpm build && pnpm lint`. See
https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md

### Fixing a bug

- Related issues linked using `fixes #number`
- Tests added. See:
https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md

### Adding a feature

- Implements an existing feature request or RFC. Make sure the feature
request has been accepted for implementation before opening a PR. (A
discussion must be opened, see
https://github.com/vercel/next.js/discussions/new?category=ideas)
- Related issues/discussions are linked using `fixes #number`
- e2e tests added
(https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs)
- Documentation added
- Telemetry added. In case of a feature if it's used or not.
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md


## For Maintainers

- Minimal description (aim for explaining to someone not on the team to
understand the PR)
- When linking to a Slack thread, you might want to share details of the
conclusion
- Link both the Linear (Fixes NEXT-xxx) and the GitHub issues
- Add review comments if necessary to explain to the reviewer the logic
behind a change

### What?

### Why?

### How?

Closes NEXT-
Fixes #

-->

Co-authored-by: JJ Kasper <jj@jjsweb.site>
@pull pull bot added the ⤵️ pull label May 2, 2025
@pull pull bot merged commit d6fd8d5 into code:canary May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants