Guard against divide by zero error #145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug where empty js file could cause an analysis to error
|
I slightly disagree with the rubocop setting we have that's telling me to because I think it's less explicit and mathematical, but going to comply for now. |
wfleming
reviewed
Oct 24, 2016
| if content.lines.count != 0 | ||
| ratio = content.chars.count / content.lines.count | ||
| ratio >= MINIFIED_AVG_LINE_LENGTH_CUTOFF | ||
| end |
There was a problem hiding this comment.
I saw a comment on another PR this morning suggesting that a ? method should probably return a bool, which made sense to me. In which case an else... false branch here might make sense.
|
@wfleming updated! |
|
LGTM |
|
Oo good catch. This was inspired by the eslint checker y'all wrote a few months ago, but I forgot that JS is a little more loosey-goosey with math 😬 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where empty js file could cause an analysis to error
e.g. https://codeclimate.com/github/parliamentofowls/test-repo-cc/builds/1
@codeclimate/review