Skip to content

Doesn't load project plugins #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tmoitie opened this issue Jun 26, 2015 · 15 comments
Closed

Doesn't load project plugins #10

tmoitie opened this issue Jun 26, 2015 · 15 comments

Comments

@tmoitie
Copy link

tmoitie commented Jun 26, 2015

My eslintrc file is trying to use the react plugin which is not loaded by the analyzer engine

error: (CC::Analyzer::Engine::EngineFailure) engine eslint failed with status 1 and stderr "module.js:338\n throw err;\n ^\nError: Cannot find module 'eslint-plugin-react'\n at Function.Module._resolveFilename (module.js:336:15)\n at Function.Module._load (module.js:278:25)\n at Module.require (module.js:365:17)\n at require (module.js:384:17)\n at /usr/src/app/node_modules/eslint/lib/cli-engine.js:107:26\n at Array.forEach (native)\n at loadPlugins (/usr/src/app/node_modules/eslint/lib/cli-engine.js:98:21)\n at processFile (/usr/src/app/node_modules/eslint/lib/cli-engine.js:179:5)\n at /usr/src/app/node_modules/eslint/lib/cli-engine.js:332:26\n at /usr/src/app/node_modules/eslint/lib/util/traverse.js:61:17\n"

@gdiggs
Copy link
Contributor

gdiggs commented Jun 26, 2015

Thanks! I'm putting this in our roadmap and will fix soon

@tmoitie
Copy link
Author

tmoitie commented Jul 13, 2015

Hullo. Has this PR made it into release? If so how do I update?

Thanks!

@gdiggs
Copy link
Contributor

gdiggs commented Jul 16, 2015

@tmoitie We had to revert it because we actually can't support plugins just yet. I'm going to leave this issue open for now and will update it when we push support for them!

@jdelStrother
Copy link
Contributor

In the meantime, any suggestions on continuing to use eslint-plugin-react locally, but disabling it when running under codeclimate? Can I point codeclimate's engine to a different .eslintrc or something?

@jakemhiller
Copy link
Contributor

Yeah, Having the same issue. Along with the react plugin we also use the babel-eslint parser, which was mentioned in another issue. It would be nice to at least have a work-around like what @jdelStrother mentioned.

@mattdaw
Copy link

mattdaw commented Aug 18, 2015

👍 My project is blocked by this as well.

@abritinthebay
Copy link

Ditto. At the very least supporting the react plugin will allow support of all the react code coming down the pipe.

While ESlint killed support of React semantics in JSX (which makes sense, tho I wish they'd just have a JSX plugin at that point) this is basically required for any JSX work that uses components (ie - most of it)

@gdiggs
Copy link
Contributor

gdiggs commented Oct 13, 2015

Hey all! We are now bundling the eslint-plugin-react, eslint-plugin-babel and babel-eslint packages with this engine, so you should be able to use them moving forward!

@gdiggs gdiggs closed this as completed Oct 13, 2015
@gdiggs
Copy link
Contributor

gdiggs commented Oct 13, 2015

We hope to bring more general support for plugins in the future

@kachkaev
Copy link

kachkaev commented Feb 8, 2016

Hey guys,

Any updates in your plans on eslint plugin support?

No worries if the feature can't be done in the nearest future. In this case, it would be nice if the issue was reflected in the docs somehow. It took me a pretty long while to discover the basis of an error I saw in the codeclimate report. To be more precise, I was googling for codeclimate "Definition for rule" "was not found" but that did not return anything informative.

@averyvery
Copy link

averyvery commented Apr 29, 2016

Tagging onto this; we have a project eslinting with the jsx-control-statements plugin (and extends:ed rules) and it would be great if Code Climate could pick this up when linting our JS.

@pgoldrbx
Copy link

Adding a bump here — specifically, eslint-plugin-flowtype (though, tbh, I may move away from flow in favor of more robust tests)

@athyuttamre
Copy link

+1 I'm trying to use eslint-plugin-meteor and can't get CodeClimate working.

@maxjacobson
Copy link
Contributor

@athyuttamre Hi there. You can always check our eslint docs to see the currently-supported plugins. If you'd like us to add support for another plugin, please feel free to open an issue telling us about it.

@athyuttamre
Copy link

Done, thank you! #155

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests