Skip to content

Warnings from ESLint #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
blimmer opened this issue Oct 13, 2016 · 2 comments
Closed

Warnings from ESLint #142

blimmer opened this issue Oct 13, 2016 · 2 comments

Comments

@blimmer
Copy link

blimmer commented Oct 13, 2016

It looks like codeclimate marks new warnings in results? Is that expected? Or should it ignore those warnings? Just curious.

https://codeclimate.com/github/blimmer/test-codeclimate-eslint/issues

@dblandin
Copy link
Contributor

Hey @blimmer,

That's a good question. Code Climate doesn't yet have the functionality to ignore issues based on severity, but it looks like you can control whether warnings are emitted in ESLint with the --quiet flag:

Handling warnings
--quiet

This option allows you to disable reporting on warnings. If you enable this option, only errors are reported by ESLint.

Example:
eslint --quiet file.js

source: http://eslint.org/docs/user-guide/command-line-interface#handling-warnings

I could see this option managed via the .codeclimate.yml config file. Enabling it would prompt the engine to append the --quiet flag.

---
engines:
  eslint:
    enabled: true
    channel: eslint-3
    config:
      ignore_warnings: true

A downside is that you wouldn't see these warnings anywhere in the codeclimate.com interface, since they would cease to be emitted by the engine. Might be a good workaround for now though.

@dblandin
Copy link
Contributor

dblandin commented Nov 3, 2016

This was implemented in #144. Going to go ahead and close this issue! Thanks!

@dblandin dblandin closed this as completed Nov 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants