Allow plugins to be loaded from /code/node_modules #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Doesn't this only fix this specific plugin? Don't we need to support the user having their own plugins in |
|
@pbrisbin ready for another look |
| @@ -10,4 +10,6 @@ USER app | |||
|
|
|||
| COPY . /usr/src/app | |||
|
|
|||
| ENV NODE_PATH /code/node_modules | |||
There was a problem hiding this comment.
Should this be something like /code/node_modules:/usr/src/app/node_modules?
There was a problem hiding this comment.
and even :/whatever/the/system/node_modules too?
There was a problem hiding this comment.
Nope - by default it is nothing and is only used when the module can't be found elsewhere:
If the NODE_PATH environment variable is set to a colon-delimited list of absolute paths, then node will search those paths for modules if they are not found elsewhere.
- https://nodejs.org/api/modules.html#modules_loading_from_the_global_folders
|
LGTM |
gdiggs
added a commit
that referenced
this pull request
Jun 30, 2015
Allow plugins to be loaded from /code/node_modules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @codeclimate/review
This fixes the recurring bugsnag as well as #10