Skip to content

Allow plugins to be loaded from /code/node_modules #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 30, 2015
Merged

Allow plugins to be loaded from /code/node_modules #12

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d2d5717
Add eslint-plugin-react
gdiggs Jun 30, 2015
bb0d51d
Allow packages in the code directory #10 #4
gdiggs Jun 30, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,6 @@ USER app

COPY . /usr/src/app

ENV NODE_PATH /code/node_modules
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be something like /code/node_modules:/usr/src/app/node_modules?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and even :/whatever/the/system/node_modules too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope - by default it is nothing and is only used when the module can't be found elsewhere:

If the NODE_PATH environment variable is set to a colon-delimited list of absolute paths, then node will search those paths for modules if they are not found elsewhere.

- https://nodejs.org/api/modules.html#modules_loading_from_the_global_folders

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!


CMD ["/usr/src/app/bin/eslint.js"]