Add ember-suave plugin #140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! This looks great to me. Do you think any of these rules might benefit from a non-default category mapping? I could see some of the ember-suave rules failing into the https://github.com/codeclimate/spec/blob/master/SPEC.md#categories https://github.com/codeclimate/codeclimate-eslint/blob/master/lib/checks.js |
|
@dblandin IMO all the rules defined by the ember-suave plugin are purely stylistic concerns. The rest of the configuration tweaks configuration of the If they continue to port other rules over to eslint (like deprecation warnings) which exist in their jscs flavored config, it will make sense to tweak the clarity section, but I'm happy to do a PR to add those improvements as they're ported over. |
|
@blimmer Sounds good to me! I'll go ahead and merge this in. An updated image will be available via the CLI shortly. You can update your local engines with Thanks! |
|
Sounds great. Thanks for the quick turnaround and I'll look forward to turning on eslint on codeclimate today! |
|
@blimmer Just released this update to codeclimate.com. Let me know if you run into any issues! Thanks again for the contribution! |
pointlessone
pushed a commit
that referenced
this pull request
Feb 23, 2017
pointlessone
pushed a commit
that referenced
this pull request
Feb 23, 2017
pointlessone
pushed a commit
that referenced
this pull request
Feb 23, 2017
gdiggs
pushed a commit
that referenced
this pull request
Feb 28, 2017
* Monkey patch eslint, instead of modifying it
- Add access to ESLint docs
- Add support for parametrized Docker builds, building different
versions of the documentation
- Automatically detect which version of the docs we should be including
* Use eslint-2.4.0
Fixes:
npm WARN eslint-config-airbnb@6.2.0 requires a peer of eslint@^2.4.0 but none was installed.
npm WARN codeclimate-eslint@0.0.3 No license field.
Cloning into 'eslint'...
npm ERR! peer dep missing: eslint@^2.4.0, required by eslint-config-airbnb@6.2.0
npm ERR! code 1
error: pathspec 'vnull' did not match any file(s) known to git.
* Comment loadPackage override
Fixes:
/usr/src/app/node_modules/meld/meld.js:67
if (typeof target[pointcut] === 'function') {
^
TypeError: Cannot read property 'loadPackage' of undefined
at meld (/usr/src/app/node_modules/meld/meld.js:67:23)
at Function.around (/usr/src/app/node_modules/meld/meld.js:436:12)
at patcher (/usr/src/app/lib/eslint-patch.js:21:8)
at Object.<anonymous> (/usr/src/app/bin/eslint.js:11:44)
at Module._compile (module.js:397:26)
at Object.Module._extensions..js (module.js:404:10)
at Module.load (module.js:343:32)
at Function.Module._load (module.js:300:12)
at Function.Module.runMain (module.js:429:10)
at startup (node.js:139:18)
* Update babel-eslint to v6
Fixes #91
* Update dependencies
```
eslint@2.4.0 -> eslint@2.10.2
eslint-config-airbnb@6.0.2 -> eslint-config-airbnb@9.0.1
eslint-plugin-babel@2.1.1 -> eslint-config-airbnb@3.2.0
eslint-plugin-react@4.0.0 -> eslint-config-react@5.1.1
```
* Add standard style plugin and shared config
* Vendor additional Standard Style config packages (#102)
Many users using [Standard Style][] also use these configuration packages when
writing React/JSX.
[Standard Style]: https://github.com/feross/standard
This commit vendors the [eslint-config-standard-react] and
[eslint-config-standard-jsx] packages.
[eslint-config-standard-react]: https://github.com/feross/eslint-config-standard-react
[eslint-config-standard-jsx]: https://github.com/feross/eslint-config-standard-jsx
* Add eslint-config-google as available plugin
* Added supporto for ESLint plugin Flowtype
* Add support for eslint-config-angular
* Add task to update npm-shrinkwrap.json
* Update package.json (#112)
eslint-2: Vendor eslint-plugin-angular package
* add eslint-config-ember package
* Switch base image to avoid Segfault
Related to #111, a Segfault occurs when we hammer STDOUT with issues.
Switching from alpine to a debian-based image seems to behave better in
this scenario.
* Update babel-eslint & eslint-flowtype
We're a bit behind on these. Flowtype in particular has new rules we
weren't supporting.
Looks like we hadn't actually filled in the shrinkwrap file before now,
either, so that's done.
* Add --gecos "" to avoid adduser prompt
* add hapi config support
hapi eslint config is based on eslint-config-hapi
and eslint-plugin-hapi packages
* Add eslint-config-airbnb-base as a top-level dep
eslint-config-airbnb-base is a transitive dependency of
eslint-config-airbnb, but it is useful in its own right and should be
included at the top level such that it has proper support in the eslint
engine.
* Update circle to trigger build
* Upgrade to Node 6.5.0
* Update packages for ESLint 3
* eslint-3: Added ESLint plugins (#131)
* eslint-3: Added ESLint plugins
* Added appropriate eslint-plugin rule categorizations
* Shifted category mappings to individual JSON file
* Alphabetized ESLint plugin rule category mapping
* Bump eslint to 3.6.1 & eslint-plugin-import to 1.16.0 (#136)
The eslint bump was necessitated by `airbnb-config-base` wanting it.
There's also a 2.0.0 of `eslint-plugin-import` available, but attempting
to jump that far gave some peer package errors, so maybe we can't
support that yet.
* Support eslint-plugin-ember-suave. (#140)
* Allow ignoring warnings from configuration.
* Add CONTRIBUTING.md.
The file, for now, shows how to create a local engine image for testing.
* Add ignore_warnings to README
As requested in #144.
* Update README.md
* Update project README
- Update project/documentation links
- Use open source Code Climate badge
- Hard-wrap text
- Fix YAML identation
* Upgrade ESLint & some packages
* We're several point releases behind on ESLint
* After updating just that, I got some errors from shrinkwrap for two
other packages we support, so I upgraded those too.
* Add support for eslint-plugin-react-intl plugin (#154)
* chore(packages): upgrade eslint
* docs(CONTRIBUTING): fix .codeclimate.yml example
* feat(config): add eslint-config-simplifield
* Switch to yarn for installing dependencies
This seems more intuitive to me today, and I hope will make it easier
for contributors who want to add or upgrade plugins.
Note: this is using nightly yarn, because there's a fix for Circle CI +
Docker + Yarn compatibility that is made but not officially released
yet. We can switch to stable yarn once 0.18.0 leaves pre-release. The
fix was PR 1837 on the Yarn repo.
* Upgrade eslint-config-google to 0.7.1
* Add eslint-plugin-meteor
Close #155
Just ran: `bin/yarn add eslint-plugin-meteor`
* Add eslint-plugin-immutable
`bin/yarn add eslint-plugin-immutable`
* Add eslint-plugin-import-order
`bin/yarn add eslint-plugin-import-order`
* Add eslint-plugin-jasmine
`bin/yarn add eslint-plugin-jasmine`
* Add eslint-config-semistandard
`bin/yarn add eslint-config-semistandard`
* Yarn add eslint-config-react-app
Yarn upgrade babel-eslint ^7.0.0
Yarn upgrade eslint-plugin-flowtype to ^2.21.0
Yarn upgrade eslint-plugin-import to ^2.0.1
Yarn upgrade eslint-plugin-jsx-a11y to ^2.2.3
Yarn upgrade eslint-plugin-react to ^6.4.1
* added eslint-plugin-xogroup plugin
* Upgrade eslint
```
make
bin/yarn upgrade eslint
```
We'd like to pull in a fix for a bug that prevents using this rule:
http://eslint.org/docs/2.0.0/rules/generator-star-spacing
* add support for eslint prettier plugin
* Add config upgrader
Automatically upgrade pre-ESLint 3 config to ESLint 3-compatible format.
* Fix null-config issue with upgrader
When upgrader encountered a project that had no .eslintrc* but had an
unrelated package.json that had no ESLint-related options in it an
exception was thrown.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original jscs flavor of ember-suave is the 27th most used addon in the EmberJS ecosystem. As of a few weeks ago, this configuration has migrated to an eslint-plugin (eslint-plugin-ember-suave) and they plan to make this the default for the ember suave plugin.
For the ember community, this is an excellent addition and, for my team, it's required to use codeclimate on our projects.
Merging this PR would resolve #139