Add eslint-plugin-import resolvers for node and webpack #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wfleming
reviewed
Oct 17, 2016
| "eslint-config-google": "^0.6.0", | ||
| "eslint-config-hapi": "^10.0.0", | ||
| "eslint-config-standard": "^6.0.0", | ||
| "eslint-config-standard-jsx": "^3.0.0", | ||
| "eslint-config-standard-react": "^4.0.0", | ||
| "eslint-import-resolver-node": "https://registry.npmjs.org/eslint-import-resolver-node/-/eslint-import-resolver-node-0.2.3.tgz", |
There was a problem hiding this comment.
This package appears to be actually released, why do we need to install via a tgz like this?
There was a problem hiding this comment.
Hmmm, good question. This came directly out of a npm install --save. 🤷
|
One question, but LGTM. |
This commit adds two npm packages that support [eslint-plugin-import][]. [eslint-plugin-import]: https://github.com/benmosher/eslint-plugin-import - [eslint-import-resolver-webpack][] - [eslint-import-resolver-node][] [eslint-import-resolver-webpack]: https://www.npmjs.com/package/eslint-import-resolver-webpack [eslint-import-resolver-node]: https://www.npmjs.com/package/eslint-import-resolver-node More details on how [eslint-plugin-import][] implements resolvers can be found [in its README][resolvers]. [resolvers]: https://github.com/benmosher/eslint-plugin-import#resolvers
e50320d to
197e6aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds two npm packages that support eslint-plugin-import.
More details on how eslint-plugin-import implements resolvers can be
found in its README.
Addresses #143
@codeclimate/review 🔎