Revert "Add eslint-plugin-import resolvers for node and webpack" #148
Conversation
This reverts commit ac35f7e. Unfortunately, this behavior doesn't seem to work when modules are imported in source code but not installed via npm, as is the case when running static analysis builds on codeclimate.com.
|
Sounds good to me. The only thought would be if there are other checks provided by this plugin that do work in the context of an engine. If so though, I still think we'd have to do something to improve the default experience, since currently having this here pretty much guarantees a bunch of confusing issues from that check that doesn't work. |
|
Yep, in particular the I think some of these rules could be re-introduced along with a new blacklist that prevents actual module lookup. |
|
We're currently hitting this problem with Webpack, eslint and codeclimate. Can you add more context to this? I'm confused about this revert. Requiring packages that aren't installed via npm should clearly raise a linting error. In the case of the screenshot, glob and stylelint aren't default node packages, so if their source isn't explicitly stated, why wouldn't you want to error? |
This reverts commit ac35f7e.
Unfortunately, this behavior doesn't seem to work when modules are
imported in source code but not installed via npm, as is the case when
running static analysis builds on codeclimate.com.
@codeclimate/review 🔎