Fix error when there are no config files #183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the following error:
TypeError: Reduce of empty array with no initial value
at Array.reduce (native)
at Function.upgradeInstructions (/usr/src/app/lib/config_upgrader.js:272:20)
at Object.<anonymous> (/usr/src/app/bin/eslint.js:239:37)
at Module._compile (module.js:556:32)
at Object.Module._extensions..js (module.js:565:10)
at Module.load (module.js:473:32)
at tryModuleLoad (module.js:432:12)
at Function.Module._load (module.js:424:3)
at Module.runMain (module.js:590:10)
at run (bootstrap_node.js:394:7)
I couldn't find a good initial value to give to `reduce` to obtain the
correct functionality. There's no reason to reduce anyway if there are
no reports.
nporteschaikin
approved these changes
Feb 28, 2017
| @@ -269,7 +269,11 @@ class ConfigUpgrader { | |||
| return report; | |||
| }); | |||
|
|
|||
| return reports.reduce(function(a, b) { return a.concat([""]).concat(b); }); | |||
| if (reports.length > 0) { | |||
There was a problem hiding this comment.
You could also simply do if (reports.length) here.
There was a problem hiding this comment.
I like the explicitness of > 0 here. The fact that 0 is falsy makes me squirm heh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the following error:
I couldn't find a good initial value to give to
reduceto obtain thecorrect functionality. There's no reason to reduce anyway if there are
no reports.