Skip to content

Add more packages and blocklist more rules #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 12, 2017
Merged

Add more packages and blocklist more rules #342

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
95c54ae
Add a variety of popular packages
gdiggs Oct 12, 2017
2bf2cec
Add some more blocklisted rules
gdiggs Oct 12, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion lib/rule_blocklist.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,18 @@ const Config = require("eslint/lib/config")
, merge = require("eslint/lib/config/config-ops").merge;

const blocklistedRules = [
"import/extensions",
"import/no-restricted-paths",
"import/no-unresolved",
"node/no-hide-code-modules"
"import/no-extraneous-dependencies",
"import/no-named-as-default",
"import/namespace",
"import/named",
"import/no-absolute-path",
"import/no-duplicates",
"import/no-named-as-default-member",
"node/no-hide-code-modules",
"node/no-missing-require"
];

function filterRules(rules) {
Expand Down
19 changes: 19 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,23 +15,39 @@
"eslint-config-airbnb-base": "^11.1.3",
"eslint-config-angular": "^0.5.0",
"eslint-config-apiconnect": "^2.0.1",
"eslint-config-dbk": "^2.0.0",
"eslint-config-drupal": "^3.0.0",
"eslint-config-ember": "^0.3.0",
"eslint-config-es5": "^0.5.0",
"eslint-config-es6": "^1.10.3",
"eslint-config-google": "^0.7.1",
"eslint-config-hapi": "^10.0.0",
"eslint-config-jquery": "^1.0.1",
"eslint-config-loopback": "^8.0.0",
"eslint-config-nightmare-mode": "^2.3.0",
"eslint-config-nodesecurity": "^1.3.1",
"eslint-config-prettier": "^1.5.0",
"eslint-config-react-app": "^0.6.2",
"eslint-config-secure": "^0.2.1",
"eslint-config-semistandard": "^11.0.0",
"eslint-config-signavio": "^3.2.0",
"eslint-config-signavio-test": "^2.0.0",
"eslint-config-simplifield": "^5.0.1",
"eslint-config-standard": "^10.0.0",
"eslint-config-standard-jsx": "^4.0.0",
"eslint-config-standard-react": "^5.0.0",
"eslint-config-strongloop": "^2.1.0",
"eslint-config-vue": "^2.0.2",
"eslint-config-xo": "^0.18.2",
"eslint-config-xo-react": "^0.13.0",
"eslint-config-xo-space": "^0.16.0",
"eslint-import-resolver-node": "^0.3.1",
"eslint-import-resolver-webpack": "^0.8.3",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've had trouble with these revolvers in the past. Do we need to include them if we're blocklisting some of the import/ rules?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we do because the blocklisting happens when we report the issues. If we don't have these here, the analysis will error working with the config, right?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, probably... sounds good to me.

"eslint-plugin-angular": "^2.0.0",
"eslint-plugin-ava": "^4.2.1",
"eslint-plugin-babel": "^4.1.1",
"eslint-plugin-backbone": "^2.1.1",
"eslint-plugin-drupal": "^0.3.1",
"eslint-plugin-ejs": "^0.0.2",
"eslint-plugin-ember": "^4.5.0",
"eslint-plugin-ember-suave": "^1.0.0",
Expand All @@ -55,6 +71,8 @@
"eslint-plugin-meteor": "^4.0.1",
"eslint-plugin-mocha": "^4.8.0",
"eslint-plugin-mongodb": "^0.2.4",
"eslint-plugin-no-only-tests": "^2.0.0",
"eslint-plugin-no-unsafe-innerhtml": "^1.0.16",
"eslint-plugin-node": "^4.2.1",
"eslint-plugin-prettier": "^2.0.1",
"eslint-plugin-promise": "^3.5.0",
Expand All @@ -65,6 +83,7 @@
"eslint-plugin-scanjs-rules": "^0.1.5",
"eslint-plugin-security": "^1.3.0",
"eslint-plugin-sort-class-members": "^1.1.1",
"eslint-plugin-sorting": "^0.3.0",
"eslint-plugin-standard": "^3.0.0",
"eslint-plugin-unicorn": "^2.1.2",
"eslint-plugin-vue": "^2.0.1",
Expand Down
Loading