Create branch for new channel based on the latest channel instead of master #193
Conversation
bin/newver
Outdated
| git checkout -b "newver/${NEWVER}" | ||
|
|
||
| ed Gemfile <<-EDITS | ||
| /gem "parser",/c | ||
| /gem "parser"/c |
There was a problem hiding this comment.
can I be honest? I have no idea how to use ed or what this change accomplishes. Would you mind providing some context?
There was a problem hiding this comment.
hahaha struggled with this a bit too, never fully learned ed...
On master, this line is:
gem "parser", "~> 2.4.0"
But recent channels it is:
gem "parser"
The change make sure on either case the result is just gem "parser"... which could actually go away since it accomplishes nothing in the new approach for forking from latest channel... just realizing now that I am explaining it.
bin/newver
Outdated
| previous_channel() { | ||
| ruby -e "version = \"${NEWVER}\".match(/(\d+).(\d+).(\d+)/); \ | ||
| minor = version[2].to_i - 1; \ | ||
| puts \"channel/rubocop-#{version[1]}-#{minor}\"" |
There was a problem hiding this comment.
This is very clever. IMO it wouldn't be crazy to rewrite this whole script in ruby with a #!/usr/bin/env ruby shebang if that will make this all easier
Happy to stick with this, though. It might make your life a little easier to do something like:
cat <<EOM | ruby
ruby goes here without need of escaping quotes
EOM
No description provided.