QUA-619: remove mry gem (beta) #328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dantevvp you should also remove spec/support/config_upgrader_rubocop.yml because it's only used in that deleted test. |
f-moya
approved these changes
Aug 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
mrygem and theConfigUpgraderclass, that was using that gem to migrate older rubocop configuration attributes to their newer equivalents.The
mrygem is intended to be used in pre-1.0 versions of rubocop. In more recent versions, this gem seems to behave unpredictably, breaking some specific cops, so there's a reason to remove it entirely for rubocop versions post 1.0The
ConfigUpgraderclass was removed because it's sole purpose was to usemryto migrate config files.Example:
This is the CLI analyzing a piece of code with rubocop version 1.22.3, while using
mryto migrate configsWhen removing the mry gem, running the same analysis on the same piece of code returns this:
NOTE: the removal of this gem makes the engine produce more issues compared to previous versions in some cases. There might be a big difference in new issues that weren't being caught before when using this update (between 10-100 in large codebases).