QUA-958: Push images to Dockerhub instead of GCR #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RubyBrewsday
approved these changes
Feb 13, 2023
f-moya
reviewed
Mar 1, 2023
Comment on lines
+6
to
+8
| ifndef RELEASE_TAG | ||
| override RELEASE_TAG = latest | ||
| endif |
There was a problem hiding this comment.
Suggested change
| ifndef RELEASE_TAG | |
| override RELEASE_TAG = latest | |
| endif | |
| RELEASE_TAG ?= latest |
There was a problem hiding this comment.
this does not work when providing an empty string. Makefile takes empty strings as not null, so it'll end up not tagging the image as latest. The ifndef workaround lets us provide an empty string that will still be replaced with latest
There was a problem hiding this comment.
this does not work when providing an empty string.
That's expected isn't it ? Why would you run make release RELEASE_TAG="" ?
f-moya
reviewed
Mar 10, 2023
| us.gcr.io/code-climate/codeclimate-sonar-php:b$CIRCLE_BUILD_NUM | ||
| docker push us.gcr.io/code-climate/codeclimate-sonar-php:b$CIRCLE_BUILD_NUM | ||
| make release RELEASE_TAG="b$CIRCLE_BUILD_NUM" | ||
| make release RELEASE_TAG="$(echo $CIRCLE_BRANCH | grep -oP 'channel/\K[\w\-]+')" |
There was a problem hiding this comment.
@dantevvp does this means we will be pushing images like codeclimate-sonar-php:master ? if so which service will be using it ? I'm asking because I don't remember having seen an image tag :master before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate pushing of the image to GCR in favor of pushing to Dockerhub.