This repository was archived by the owner on Sep 16, 2021. It is now read-only.
Remove npm-shrinkwrap file #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Including the `npm-shrinkwrap.json` file [causes an npm error][issue] for users installing the `codeclimate-test-reporter` package on Node `4`. Since shrinkwrap-ing doesn't provide much value in the context of a published package, this commit simply removes the file. [issue]: #41
We removed the `npm-shrinkwrap.json` file so this engine is no longer appropriate.
|
@dblandin I'm curious about whether the mismatch between the shrinkwrap and package.json files could be the culprit here. WDYT about cutting the shrinkwrap down, as in: https://github.com/codeclimate/javascript-test-reporter/compare/abh-update-shrinkwrap?expand=1 |
While that will technically work, what you propose is practically equivalent to removing the file entirely. An empty |
|
Okay. 👍 fine with removing |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including the
npm-shrinkwrap.jsonfile causes an npm error for usersinstalling the
codeclimate-test-reporterpackage on Node4.Since shrinkwrap-ing doesn't provide much value in the context of a published
package, this commit simply removes the file.
@codeclimate/review 🔎