Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: codeclimate/ruby-test-reporter
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: codeclimate/ruby-test-reporter
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: pb-refactor
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 8 commits
  • 18 files changed
  • 2 contributors

Commits on Sep 9, 2016

  1. Reporter no longer runs SimpleCov, but aggregates/posts results instead

    Due to a history of legacy functionality changes with the reporter and
    on codeclimate.com, this reporter had one major flaw that because of
    the circumstances didn't really bother anyone: if tests failed or errors
    occurred during a test run, the reporter would still report coverage
    to codeclimate.com. This has started to become a problem since we have
    released a browser extension and other features which leverage test reports
    on non-master or 'default' branches.
    
    The solution is to make this reporter similar to the others for the major
    languages we support. Instead of including a snippet in a test/spec helper
    which initiates and runs SimpleCov and then posts results to codeclimate,
    users will now do what they did before: include the SimpleCov snippet in
    their helpers. After tests, users will execute the added bin/codeclimate-ruby
    binary, which will aggregate and format results before posting them to
    codeclimate. This obviates the "partial results" problem because your CI
    script will not reach the line where you run bin/codeclimate-ruby if there
    is an error or failure.
    
    We will now have parity between how this reporter is used and how others
    are used, and the presenting issues should be mitigated.
    mrb committed Sep 9, 2016
    Configuration menu
    Copy the full SHA
    bba6404 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2016

  1. Configuration menu
    Copy the full SHA
    bfbcbe0 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2016

  1. Silence noisy specs

    pbrisbin committed Sep 13, 2016
    Configuration menu
    Copy the full SHA
    6490ca3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5ee69b0 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2016

  1. Extract ShortenFilename from Formatter

    Mixed concerns made specs brittle and failure prone
    mrb committed Sep 19, 2016
    Configuration menu
    Copy the full SHA
    38aded0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    382f7ee View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2016

  1. Configuration menu
    Copy the full SHA
    54b5073 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2016

  1. Styling fixes as per RuboCop

    mrb committed Sep 21, 2016
    Configuration menu
    Copy the full SHA
    9ba080f View commit details
    Browse the repository at this point in the history
Loading