Clean up Code Climate rubocop style issues #118
Conversation
| end | ||
|
|
||
| def clean_git_branch | ||
| git_branch = String(branch_from_git) | ||
| clean = git_branch.sub(/^origin\//, "") unless git_branch.start_with?("(") | ||
| clean = git_branch.sub(%r{^origin\/}, "") unless git_branch.start_with?("(") |
There was a problem hiding this comment.
I believe the idea with this cop is that using %r{} means that / no longer delimits the beginning and end of the regular expression, so now you're free to no longer escape /'s which appear in the middle of the pattern
There was a problem hiding this comment.
(This, apparently, is called "leaning toothpick syndrome")
There was a problem hiding this comment.
Oo cool. Thanks! Updating
fc25adb to
7b8c927
Compare
| @@ -39,11 +39,11 @@ def format(result) | |||
| # actually private ... | |||
| def short_filename(filename) | |||
| return filename unless ::SimpleCov.root | |||
| filename = filename.gsub(/^#{::SimpleCov.root}/, ".").gsub(/^\.\//, "") | |||
| filename = filename.gsub(/^#{::SimpleCov.root}/, ".").gsub(%r{^./}, "") | |||
There was a problem hiding this comment.
The . probably still needs to be escaped, if it's meant to be a literal . and not the regex wildcard
There was a problem hiding this comment.
Thanks :) good catch
|
LGTM |
| def initialize(file_path) | ||
| @file_path = file_path | ||
| end | ||
|
|
||
| def blob_id | ||
| calculate_with_file or calculate_with_git | ||
| calculate_with_file || calculate_with_git |
There was a problem hiding this comment.
ah, one last note: we recently updated our styleguide to allow this kind of usage of or (codeclimate/styleguide@3aa6d71) so might be worth considering leaving this one, but up to you
There was a problem hiding this comment.
Oo I like that. Updated. Thanks!
e60d519 to
d781e86
Compare
d781e86 to
3fd9246
Compare
@codeclimate/review