Bump version and add branch to reporting #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| if ci_branch | ||
| ci_branch.sub(/^origin\//, "") | ||
| elsif git_branch && !git_branch.to_s.strip.start_with?("(") |
There was a problem hiding this comment.
To be safe against empty strings, the ci_branch and git_branch checks should probably become foo.to_s.strip.size > 0. Makes you miss ActiveSupport, eh?
brynary
added a commit
that referenced
this pull request
Sep 17, 2013
Bump version and add branch to reporting
|
Merged. Gem needs release. Do you have privileges for that? |
|
@brynary I don't think so! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows us to report to the user which branch the gem believes it is sending a test report for.