test on both 1.9.3 and 2.2.2 #133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM This is more re: #132, but: I want to make sure that when we include the gem in a non-1.9.3 ruby project that it doesn't require changing your json dependency version. I don't think it will, but we should double check. if it does, it might make sense to change our recommendation and encourage people to install the gem as a discrete CI step rather than through their Gemfile. We should cut an rc and probably go to 1.0.0 soon :) |
|
Good points, @maxjacobson. I think that's a "burn that bridge when we cross it" kind of deal 😄. I think the version dep added there was intentionally left loose to make that less likely. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@codeclimate/review this is changes our CI tests to run against both 1.9.3 and 2.2.2 for a bit more assurance of compatibility.