Skip to content

Do not format coverage result when exiting forked process #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Do not format coverage result when exiting forked process #86

wants to merge 1 commit into from

Conversation

JacobNinja
Copy link
Contributor

Before: Every forked process will attempt to send coverage results

cc:analyzer jacob$ CODECLIMATE_REPO_TOKEN=xxx bundle exec rake spec:integration
I, [2015-04-28T10:30:01.530853 #86241]  INFO -- : Reporting coverage data to Code Climate.
Run options: include {:focus=>true}

All examples were filtered out; ignoring {:focus=>true}
Coverage = 13.46%. Coverage = 13.08%. Sending report to https://codeclimate.com for branch jr-disable_language... Sending report to https://codeclimate.com for branch jr-disable_language... Code Climate encountered an exception: RuntimeError
HTTP Error: 401

After:

cc:analyzer jacob$ CODECLIMATE_REPO_TOKEN=xxx bundle exec rake spec:integration
I, [2015-04-28T10:30:56.158738 #86317]  INFO -- : Reporting coverage data to Code Climate.
Run options: include {:focus=>true}

All examples were filtered out; ignoring {:focus=>true}
.....

Finished in 45.41 seconds
5 examples, 0 failures
Coverage = 64.19%. Sending report to https://codeclimate.com for branch jr-disable_language... Code Climate encountered an exception: RuntimeError
HTTP Error: 401

@noahd1
Copy link
Contributor

noahd1 commented Apr 28, 2015

Interesting. Does the master test coverage process have the coverage data of all the sub-processes/children?

@JacobNinja
Copy link
Contributor Author

@noahd1 nope that data is discarded. forked processes use "copy on write" so shared memory cannot be written to directly.

It's possible to write the forked results to disk (or pipe) and collect them before formatting the total result.

@noahd1
Copy link
Contributor

noahd1 commented Apr 28, 2015

Right, so it'll be an incomplete test coverage report. We just need to implement support for multiple POSTs (which we're working on)

@JacobNinja
Copy link
Contributor Author

@noahd1 the problem occurs because of multiple POST payloads. The test suite becomes unstable and crashes frequently

@brynary
Copy link
Member

brynary commented May 4, 2015

@noahd1 said we should close this for now, because of concerns around the implementation and also lack of priority.

@brynary brynary closed this May 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JacobNinja @noahd1 @brynary