Encode s3 upload data as utf8 #121
Conversation
Resolves #85
|
I'm still having this issue in https://circleci.com/gh/ethereum/cpp-ethereum/2049. v2.0.11. |
|
This patch is live in v2.0.11. But It appears @chfast is still having issues with it... |
|
This error message is different than the one I was seeing. My error message: This error message: This SO post seems relevant: https://stackoverflow.com/questions/21129020/how-to-fix-unicodedecodeerror-ascii-codec-cant-decode-byte I'm not an expert in this area, though. I just applied the change suggested here and it fixed the issue I was running into. |
|
Some additional information about bug #130.
|
|
I can confirm it's v2.0.11 regression. After Linux auto-upgraded to v2.0.11 I have the same issue there too. |
|
It looks like this PR created the issue #130. Not sure where the |
| @@ -719,7 +719,7 @@ def main(*argv, **kwargs): | |||
| result, upload_url = res[0], res[1] | |||
|
|
|||
| write(' Uploading to S3...') | |||
| s3 = requests.put(upload_url, data=reports, | |||
| s3 = requests.put(upload_url, data=reports.encode('utf-8'), | |||
There was a problem hiding this comment.
This is bad because reports is bytes in python2 and string in python3. Only string must be encoded to bytes.
Alternatively would be to make reports a string also in python2 (there it is called unicode). You can use u'' prefix for that.
Resolves #85
I ran into this issue recently on Circle CI. After making the fix mentioned in the issue comments in a branch on my fork, I was able to successfully upload my test results to codecov.
Before: https://circleci.com/gh/JrGoodle/clowder/97
After: https://circleci.com/gh/JrGoodle/clowder/98
The output before and after the change can be seen at the bottom of the "upload code coverage results" build phase.
If I need to add any tests, just let me know how it would be preferable to test this.