Skip to content
This repository was archived by the owner on Apr 20, 2023. It is now read-only.

failing on GitLab ≥ 9 (bis) #208

Closed
wants to merge 2 commits into from
Closed

failing on GitLab ≥ 9 (bis) #208

wants to merge 2 commits into from

Conversation

romain-dartigues
Copy link

@romain-dartigues romain-dartigues commented Aug 12, 2019 •
edited
Loading

As previously listed in #96 and #97, GitLab 9.0 (released in March 2017) renamed some variables which are still used in codecov.

The following patch keep the compatibility with pre-9 releases (GitLab 8 was deprecated around August 2017).

https://about.gitlab.com/blog/categories/releases/

@codecov
Copy link

codecov bot commented Aug 12, 2019

Codecov Report

Merging #208 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #208   +/-   ##
=====================================
  Coverage       0%     0%           
=====================================
  Files           1      1           
  Lines           1      1           
=====================================
  Misses          1      1

1 similar comment
@codecov
Copy link

codecov bot commented Aug 12, 2019

Codecov Report

Merging #208 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #208   +/-   ##
=====================================
  Coverage       0%     0%           
=====================================
  Files           1      1           
  Lines           1      1           
=====================================
  Misses          1      1

thomasrockhu
thomasrockhu approved these changes May 27, 2020
View reviewed changes
Copy link
Contributor

@thomasrockhu thomasrockhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the commit here!

@thomasrockhu
Copy link
Contributor

Please update the conflicting files and I'll merge in

@nmoinvaz
Copy link
Contributor

@thomasrockhu I have a fixed commit in my fork. Do you want a new PR?

@thomasrockhu
Copy link
Contributor

that would be great @nmoinvaz . Please tag the new PR here and I'll merge it

@nmoinvaz nmoinvaz mentioned this pull request May 27, 2020
Merged
@nmoinvaz
Copy link
Contributor

Done #264. Thanks!

@thomasrockhu
Copy link
Contributor

Closed as a result of #264

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@thomasrockhu thomasrockhu thomasrockhu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@romain-dartigues @thomasrockhu @nmoinvaz