Use argparse standard lib #82
Conversation
|
Just a friendly bump 😄 . This would be useful for those over Python3.2. |
There was a problem hiding this comment.
I would go with something like
if sys.version_info > (3, 2) or sys.version_ifo < (2, 7):
install_requires=["requests>=2.7.9", "coverage"],
else:
install_requires=["requests>=2.7.9", "coverage", "argparse"],This would be a much better way for this so that way it does not break for versions before 2.7.
|
aww wrong button... |
There was a problem hiding this comment.
I would go with something like
if sys.version_info > (3, 2) or sys.version_info < (2, 7):
install_requires=["requests>=2.7.9", "coverage"],
else:
install_requires=["requests>=2.7.9", "coverage", "argparse"],This would be a much better way for this so that way it does not break for versions before 2.7.
And if they does not work in python and produces an traceback then this will for sure work:
if sys.version_info > (3, 2) or sys.version_info < (2, 7):
install_requires=["requests>=2.7.9", "coverage"]
else:
install_requires=["requests>=2.7.9", "coverage", "argparse"]
setup(name='codecov',
version=version,
description="Hosted coverage reports for Github, Bitbucket and Gitlab",
long_description=None,
classifiers=classifiers,
keywords='coverage codecov code python java scala php',
author='@codecov',
author_email='hello@codecov.io',
url='http://github.com/codecov/codecov-python',
license='http://www.apache.org/licenses/LICENSE-2.0',
packages=['codecov'],
include_package_data=True,
zip_safe=True,
install_requires=install_requires,
tests_require=["unittest2"],
entry_points={'console_scripts': ['codecov=codecov:main']})
Codecov Report
@@ Coverage Diff @@
## master #82 +/- ##
====================================
- Coverage 78% 75% -4%
====================================
Files 2 2
Lines 349 348 -1
Branches 81 77 -4
====================================
- Hits 275 263 -12
- Misses 51 60 +9
- Partials 23 25 +2Continue to review full report at Codecov.
|
|
Good idea. Updated. |
|
Those CI failures. |
|
Thank you 👍 |
The
argparselibrary on pypi has been deprecated and moved to the standard library:Source: argparse README
The primary use for the PyPi version of
argparseis for older versions of Python:However,
codecov-pythondoes not support these versions.