Skip to content

Update README.md #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update README.md #24

wants to merge 1 commit into from

Conversation

TomPed
Copy link
Contributor

@TomPed TomPed commented Jan 24, 2018

We want a more standard style for the Codecov example READMD.mds. I've added and moved around a few things. @larzw it looks like you've done some work on this. Would you mind reviewing the changes?

@codecov
Copy link

codecov bot commented Jan 24, 2018

Codecov Report

Merging #24 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #24   +/-   ##
=======================================
  Coverage   66.66%   66.66%           
=======================================
  Files           1        1           
  Lines           9        9           
=======================================
  Hits            6        6           
  Misses          3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0255394...b08d894. Read the comment docs.

@larzw
Copy link
Contributor

larzw commented Jan 25, 2018

LGTM 👍

@TomPed
Copy link
Contributor Author

TomPed commented Jan 25, 2018

Cool, @larzw can you merge?

@larzw
Copy link
Contributor

larzw commented Jan 25, 2018

@stevepeak can you merge? I don't have the correct rights anymore.

@raschmitt
Copy link

raschmitt commented Jul 19, 2020

@TomPed, it seems that this merge got "lost".

Still, I tried to follow your instructions regarding .Net Core to setup continuous integration trough Github actions, and even though all my .csproj files contain the <DebugType>full</DebugType> tag, when I try to generate my reports, no report gets generated, and I get the following error message:

No results, this could be for a number of reasons. The most common reasons are:
    1) missing PDBs for the assemblies that match the filter please review the
    output file and refer to the Usage guide (Usage.rtf) about filters.
    2) the profiler may not be registered correctly, please refer to the Usage
    guide and the -register switch.

Could you provide me some assistance on what am I'm doing wrong?

My repository: https://github.com/raschmitt/date-override
Action I'm trying to run: https://github.com/raschmitt/date-override/blob/master/.github/workflows/dotnet-core.yml
Action results: https://github.com/raschmitt/date-override/runs/886072938?check_suite_focus=true

@thomasrockhu thomasrockhu mentioned this pull request Aug 4, 2020
@thomasrockhu
Copy link
Contributor

Closing in favor of #30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants