Do not reset css position when using helper: clone #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@tuyen : Can you show me a demo of an issue the PR is sent for? |
|
@codef0rmer just look at the demo page... drag the button and drop in on the target. Then scroll down and watch as the button is on top of the navigation bar. I believe that's a nice example. |
|
@RWOverdijk : which demo are you pointing to? |
|
@codef0rmer THE demo. http://codef0rmer.github.io/angular-dragdrop/#/ quick demo. |
|
Oh I see. But the open issue is not about this problem. Anyways, I'll fix both issues. |
|
Alright. Sorry. I thought it would be helpful. :) |
|
Duplicate of #128 |
codef0rmer
pushed a commit
that referenced
this pull request
Oct 1, 2014
- Closes #125, #121, #99 - Fix paradox of choice ($ vs jQuery) - Closes #122 - Update jQueryUI depedency in demos and tests - Closes #130 - Restore display value if set, else use block - Closes #128, #36, #30 - Restore zIndex value always - Closes #117, #110 - Fix destroying widgets prior to initialization - Closes #111 - Allow dropping without ngModel similar to dragging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is actually a work-around for issue with CSS left, top being cleared on drag stop. This is a problem if the draggable has absolute positioning and placeholder: 'keep' is used -- the draggable disappears on drag stop. In my situation I was using helper: clone anyway, so this patch just leaves the draggable's CSS positioning alone since it never changed in the first place.
This also restores the z-index fix of a few commits ago -- the recent refactoring broke that z-index fix. The problem is that mutateDraggable is called within a $timeout() delay, so the z-index fix restores the original z-index, and then the delayed mutateDraggable just blows it away again.