Skip to content

Commit 31c9947

Browse files
authored
Merge pull request RustPython#1962 from RustPython/coolreader18/subprocess-py
Implement subprocess using _posixsubprocess and _winapi
2 parents bc1717b + e06641d commit 31c9947

File tree

19 files changed

+2289
-469
lines changed

19 files changed

+2289
-469
lines changed

Cargo.lock

Lines changed: 1 addition & 11 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Lib/asyncio/windows_utils.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,7 @@
99

1010
import _winapi
1111
import itertools
12-
# XXX RustPython TODO: msvcrt
13-
# import msvcrt
12+
import msvcrt
1413
import os
1514
import socket
1615
import subprocess

Lib/platform.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -281,10 +281,9 @@ def _syscmd_ver(system='', release='', version='',
281281
for cmd in ('ver', 'command /c ver', 'cmd /c ver'):
282282
try:
283283
info = subprocess.check_output(cmd,
284-
stderr=subprocess.DEVNULL,)
285-
# XXX RustPython TODO: more Popen args
286-
# text=True,
287-
# shell=True)
284+
stderr=subprocess.DEVNULL,
285+
text=True,
286+
shell=True)
288287
except (OSError, subprocess.CalledProcessError) as why:
289288
#print('Command %s failed: %s' % (cmd, why))
290289
continue

0 commit comments

Comments
 (0)