Skip to content

Cr 19357 update domain desc #797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 28, 2023
Merged

Cr 19357 update domain desc #797

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
85ee115
Update domain field desc for GCR
NimRegev Aug 28, 2023
0b828df
Update google-container-registry.md
NimRegev Aug 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion _docs/integrations/docker-registries/github-container-registry.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ Now that you have verified your token, we can connect the registry to Codefresh.
* **Registry name**: A unique name for this configuration.
* **Username**: Your GitHub username.
* **Password**: Your GitHub personal token.
* **Domain**: `ghcr.io`.
* **Domain**: `ghcr.io`.
* Expand **Advanced Options** and define the [**Repository Prefix**]({{site.baseurl}}/docs/integrations/docker-registries/#using-an-optional-repository-prefix) as your GitHub username.

{% include image.html
Expand Down
2 changes: 1 addition & 1 deletion _docs/integrations/docker-registries/google-container-registry.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ Configure GCR (Google Container Registry) as your Docker registry provider.
1. From the **Add Registry Provider** dropdown, select **Google Container Registry**.
1. Define the following:
* **Registry name**: A unique name for this configuration.
* **Domain**: Select the domain.
* **Domain**: Select the domain, for example, `us.gcr.io`. Make sure the _domain does not include suffixes such as the URL path_. Configuring the domain as `us.gcr.io/my_org` is incorrect and will cause builds to fail.
* **JSON Keyfile**: The content of the generated JSON key file.


Expand Down