Skip to content

Fix issue 108: Unnecessary dependency on clang/llvm for non c/cpp analysis #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

rahlk
Copy link
Collaborator

@rahlk rahlk commented Feb 21, 2025

Motivation and Context

The project had an unnecessary dependency on Clang/LLVM for non-C/C++ analyses. This caused unintended behavior in environments where LLVM was not required, particularly in Linux distributions. The fix ensures that LLVM detection logic is applied only in Darwin environments and removes redundant checks on Linux.

How Has This Been Tested?

The following tests were conducted:

  • Verified that the removal of LLVM detection does not affect non-C/C++ analyses.
  • Added new test cases to confirm that Clang/LLVM dependency is no longer checked in Linux environments.
  • Ensured that the detection logic remains intact for macOS (Darwin).
  • Ran the full test suite to confirm no regressions.

Breaking Changes

No breaking changes. The fix only removes unnecessary logic and does not impact the core functionality.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the Codellm-Devkit Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional Context

  • This change improves compatibility with Linux distributions where LLVM is not required.
  • Helps streamline dependency management for non-C/C++ analyses.
  • Ensures better separation of language-specific requirements.

Signed-off-by: Rahul Krishna <i.m.ralk@gmail.com>
Signed-off-by: Rahul Krishna <i.m.ralk@gmail.com>
Signed-off-by: Rahul Krishna <i.m.ralk@gmail.com>
…arwin. And also add some test cases.

Signed-off-by: Rahul Krishna <i.m.ralk@gmail.com>
@rahlk rahlk linked an issue Feb 21, 2025 that may be closed by this pull request
@rahlk rahlk requested a review from rofrano February 21, 2025 18:22
@rahlk
Copy link
Collaborator Author

rahlk commented Feb 21, 2025

Note: There are 21 files changed because:

  • I had introduced a typo in the previous PR where """It should return...""" -> `"""return..." which I fixed.
  • I added a test cases and test application for C Analysis

@rahlk rahlk added fix Bug fixes test Added new tests labels Feb 21, 2025
@rahlk rahlk self-assigned this Feb 21, 2025
@rahlk rahlk merged commit f706c1b into main Feb 21, 2025
@rahlk rahlk deleted the 108-unnecessary-dependency-on-clangllvm-for-non-cc-analysis branch February 21, 2025 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fixes test Added new tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unnecessary Dependency on Clang/LLVM for Non-C/C++ Analysis
1 participant