Skip to content

fix: binary-op parsing #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 5, 2023
Merged

fix: binary-op parsing #275

merged 1 commit into from
May 5, 2023

Conversation

lihebi
Copy link
Collaborator

@lihebi lihebi commented May 5, 2023

Introduced in #268, where the node.children is replaced with node.namedChildren but forgets to update the receiving variable list.

@@ -694,11 +694,11 @@ function compileExpression(node: Parser.SyntaxNode, st) {
     case "await":
       return compileExpression(node.firstNamedChild!, st);
     ...
     case "binary_operator":
     case "boolean_operator": {
-      let [left, , right] = node.namedChildren.filter(notComment);
+      let [left, , right] = node.children;
       compileExpression(left, st);
       compileExpression(right, st);

Now, both a() and b() can be recognized.

Screenshot from 2023-05-05 12-02-36

@lihebi lihebi merged commit e6130eb into codepod-io:main May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lihebi