feat: allow pod to access to names in all ancestor scopes #284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lihebi
commented
May 7, 2023
| @@ -855,6 +855,8 @@ export const createCanvasSlice: StateCreator<MyState, [], [], CanvasSlice> = ( | |||
| nodesMap.delete(change.id); | |||
| // remove from store | |||
| get().deletePod(client, { id: change.id }); | |||
| // run auto-layout | |||
| get().autoForceGlobal(); | |||
There was a problem hiding this comment.
This PR also runs auto-layout on deleting a node.
This was referenced May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now a pod can access all names defined in its ancestor scopes. The following canvas shows 4 examples:
Technical staff: this PR also supports ROOT in Node2Children map, and auto-build it.