Skip to content

[UI] Apply "Show Line Numbers" as toggle switch in sidebar #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 22, 2023
Merged

[UI] Apply "Show Line Numbers" as toggle switch in sidebar #341

merged 4 commits into from
Jun 22, 2023

Conversation

senwang86
Copy link
Collaborator

  • Add the toggle switch in sidebar
  • remove the menu item from Right Click menu.

showLineNumbers

@lihebi
Copy link
Collaborator

lihebi commented Jun 22, 2023

Awesome, thanks!

@lihebi lihebi merged commit ccf8a99 into codepod-io:main Jun 22, 2023
@senwang86 senwang86 deleted the codepod_v0_4_12 branch June 22, 2023 23:32
@forrestbao
Copy link
Collaborator

forrestbao commented Jun 23, 2023 •
edited
Loading

Thanks Sen. A minor bug. The last-run timer goes missing sometimes after "show line" is re-enabled.

@lihebi
Copy link
Collaborator

lihebi commented Jun 23, 2023

A minor bug. The last-run timer goes missing sometimes after "show line" is re-enabled.

This isn’t possible. You might have miss-interpreted the video.

li-xin-yi pushed a commit to li-xin-yi/codepod-1 that referenced this pull request Jun 23, 2023
@senwang86 @li-xin-yi
Apply "Show Line Numbers" as toggle switch in sidebar (codepod-io#341)
ba4f6e6
@senwang86
Copy link
Collaborator Author

Thanks Sen. A minor bug. The last-run timer goes missing sometimes after "show line" is re-enabled.

Do you mind sharing a screen shot of the bug? I tried it a couple of times but didn't reproduce on my end.

@senwang86 senwang86 changed the title Apply "Show Line Numbers" as toggle switch in sidebar [UI] Apply "Show Line Numbers" as toggle switch in sidebar Jun 23, 2023
@forrestbao
Copy link
Collaborator

Thanks Sen. A minor bug. The last-run timer goes missing sometimes after "show line" is re-enabled.

Do you mind sharing a screen shot of the bug? I tried it a couple of times but didn't reproduce on my end.

It's in your video above. Toward the end, when kernel up time is 35m21s
image

@senwang86
Copy link
Collaborator Author

Thanks Sen. A minor bug. The last-run timer goes missing sometimes after "show line" is re-enabled.

Do you mind sharing a screen shot of the bug? I tried it a couple of times but didn't reproduce on my end.

It's in your video above. Toward the end, when kernel up time is 35m21s image

Is it because of auto replay? In terms of "Uptime", the recording begins at 35m11s and ends at 35m28s.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@senwang86 @lihebi @forrestbao