Skip to content

[UI] Update ToC when nodesMap change #505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 6, 2023
Merged

Conversation

senwang86
Copy link
Collaborator

Summary

Test

ToC_patch

Copy link
Collaborator

@lihebi lihebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! One minor comment.

Comment on lines 462 to 467
useEffect(() => {
if (node2children.size == 0) {
buildNode2Children();
}
}, [node2children]);

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this to here:

provider.once("synced", () => {

@lihebi
Copy link
Collaborator

lihebi commented Sep 6, 2023

Thanks!

@lihebi lihebi merged commit a435d19 into codepod-io:main Sep 6, 2023
@senwang86 senwang86 deleted the ToC_patch branch September 7, 2023 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants