pod ui improve #59
Closed
pod ui improve #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
himself65
reviewed
Nov 18, 2022
ui/src/index.css
Outdated
| box-sizing: border-box; | ||
| padding: 10px 0; | ||
| } | ||
| .monaco .monaco-editor-background, .margin{ |
There was a problem hiding this comment.
lihebi
reviewed
Nov 19, 2022
There was a problem hiding this comment.
Thanks!
I prefer not to use separate css files and classNames, because
- classNames are typically defined once and used once in React components , no need to give it a name
- I want the css to be close to the React component that uses it. Cross reference is painful.
- CSS cannot have variables, but MUI’s sx property can.
So, let’s use sx property of MUI component https://mui.com/system/getting-started/the-sx-prop/
Also, I see no need to use other styling libraries (e.g., styled components) other than MUI. The sx property of MUI seems to be implemented based on styled component already.
ui/src/components/canvas.module.css
Outdated
| @@ -0,0 +1,27 @@ | |||
| .result-status__success{ | |||
There was a problem hiding this comment.
Let’s in-line these styles into the sx property of the React component to avoid creating a new className.
ui/src/index.css
Outdated
| @@ -10,4 +10,8 @@ body { | |||
| code { | |||
| font-family: source-code-pro, Menlo, Monaco, Consolas, 'Courier New', | |||
| monospace; | |||
| } | |||
| .react-monaco-editor-container { | |||
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.