Skip to content

Coder plugin: integrate new query by workspace param functionality #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Kira-Pilot opened this issue Mar 18, 2024 · 2 comments · Fixed by #126
Closed

Coder plugin: integrate new query by workspace param functionality #60

Kira-Pilot opened this issue Mar 18, 2024 · 2 comments · Fixed by #126
Assignees
Labels
enhancement New feature or request

Comments

@Kira-Pilot
Copy link
Member

The Coder API now supports querying workspaces in a deployment by the set value of a coder_parameter. We should simplify our Backstage Coder plugin API layer by integrating this new functionality.

Blocked by coder/coder#10661

@Parkreiner
Copy link
Member

Parkreiner commented Apr 29, 2024

The new CoderClient PR is now pending, so I've started on this
I think I can have a basic implementation done today, but as I recall, there were some conversations about wanting to improve some of the search logic on Coder core's side. I believe the current implementation only matches exactly, and can't do partial matches. I feel like we mentioned wanting to do partial matches, but I can't remember why

Going to dig through some of the old Slack messages to refresh my memory, and then add some notes here

@code-asher
Copy link
Member

One thing that comes to mind is maybe there is a case where a trailing slash is missing, and https://github.com/owner/repo/ in the config does not match https://github.com/owner/repo in a workspace param. Or maybe there is a case where one of them has the /tree/branch syntax and another does not?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
3 participants