chore: add StateSnapshotManager class #119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parkreiner
commented
Apr 23, 2024
Comment on lines
+136
to
+137
| const snapshotBinding = this.activeSnapshot; | ||
| this.subscriptions.forEach(cb => cb(snapshotBinding)); |
There was a problem hiding this comment.
Need to make sure that we store the starting snapshot in a separate variable, because the value of this.activeSnapshot is allowed to be replaced at any time
Otherwise, it's possible for the subscriptions to start getting processed, the snapshot to change halfway through, and then the subscriptions start notifying you about the updated snapshot, not the original one
code-asher
approved these changes
Apr 24, 2024
Comment on lines
+45
to
+46
| // for these kinds of comparisons, but it itself has an edge case | ||
| // with -0 and +0. Still need === to handle that comparison |
There was a problem hiding this comment.
Yeah, I usually call Object.is the "quadruple equals" operator, but the flipside of that is that sometimes it gets too specific for its own good lol
Comment on lines
+136
to
+137
| const snapshotBinding = this.activeSnapshot; | ||
| this.subscriptions.forEach(cb => cb(snapshotBinding)); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 1 of the ongoing API factory changes for #107
Decided to start breaking these up to make the PRs easier to digest, and start getting the ball rolling faster.
Changes made
StateSnapshotManagerclass, which makes it easy to sync external state with React'suseSyncExternalStorehook.CoderClientandCoderTokenAuthNotes
Once the PR is done, I'll start tinkering with things like Proxy objects to start figuring out if there's a way to make the class less error-prone. My hope is that I can make it so that the manager exposes a "mutable snapshot proxy", and when you mutate a property on it, that will automatically run logic to determine if the snapshot has meaningfully changed, and also notify subscriptions
My thinking is that we get the API code working (even if it's less than ideal), get it verified with tests, and then use the tests to guide refactoring.